hermes-3
hermes-3 copied to clipboard
Refactor closure so can use other forms
This refactor the current implementation of the Braginskii closure so that it will be easier to swap it out for alternative formulations. A number of new unit tests were added before the actual refactoring began, to ensure nothing is broken.
Codecov Report
:x: Patch coverage is 54.72155% with 187 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 26.39%. Comparing base (0e601f7) to head (f05be18).
Additional details and impacted files
@@ Coverage Diff @@
## master #399 +/- ##
==========================================
+ Coverage 22.50% 26.39% +3.89%
==========================================
Files 87 90 +3
Lines 8071 8107 +36
Branches 1146 1132 -14
==========================================
+ Hits 1816 2140 +324
+ Misses 6085 5748 -337
- Partials 170 219 +49
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@mikekryjak Here is the slide from my ECW presentation which explains what this PR is doing (in very high-level terms). The full presentation is too large to attach to a GitHub comment, but I can share it with you if you like.
The other thing this PR does is add some more unit tests, but hopefully those are self-explanatory.