fvtt-module-avclient-livekit icon indicating copy to clipboard operation
fvtt-module-avclient-livekit copied to clipboard

Noise Reduction

Open brunocalado opened this issue 3 years ago • 6 comments
trafficstars

Hi!

I don't know if this is possible. But, can you add a noise reduction filter?

Something like discord or skype.

brunocalado avatar Jun 01 '22 19:06 brunocalado

This is something I've done some research into and may add in the future. Unfortunately, I tried contacting Krisp (the one used by Discord), but they don't work with projects of this size.

bekriebel avatar Aug 22 '22 16:08 bekriebel

BTW, I think noise reduction is not enabled by default.

See: https://github.com/bekriebel/fvtt-module-avclient-livekit/blob/288d4476b4b84f23e425d164e38664b22dc32925/src/LiveKitClient.ts#L476-L479

Same for echo cancellation:

https://docs.livekit.io/client-sdk-js/interfaces/AudioCaptureOptions.html#noiseSuppression https://docs.livekit.io/client-sdk-js/interfaces/AudioCaptureOptions.html#echoCancellation

sebastianmarkow avatar Jul 16 '23 15:07 sebastianmarkow

BTW, I think noise reduction is not enabled by default.

See:

https://github.com/bekriebel/fvtt-module-avclient-livekit/blob/288d4476b4b84f23e425d164e38664b22dc32925/src/LiveKitClient.ts#L476-L479

Same for echo cancellation:

https://docs.livekit.io/client-sdk-js/interfaces/AudioCaptureOptions.html#noiseSuppression https://docs.livekit.io/client-sdk-js/interfaces/AudioCaptureOptions.html#echoCancellation

The client is using the default capture options and only adding additional specific requirements. noiseSuppression and echoCancellation are enabled by default and are only disabled in the module when Music Mode is enabled.

bekriebel avatar Jul 18 '23 21:07 bekriebel

https://docs.livekit.io/recipes/enhanced-noise-cancellation/

patrickporto avatar Sep 30 '24 15:09 patrickporto

https://docs.livekit.io/recipes/enhanced-noise-cancellation/

That requires the use of LiveKit's $500/mo cloud plan. I assume no one is using that for Foundry :-)

bekriebel avatar Sep 30 '24 19:09 bekriebel

Hey there 👋, Michael from LiveKit Dev Rel.

I created PR #73 to add LiveKit's Krisp noise cancellation.

Yes, it does require you to use a cloud account in order to have noise cancellation, however, it can be on the free tier. You don't need to have a paid account. It may log an error if you're not using LiveKit Cloud, but should work just fine.

I also took the liberty of updating the LiveKit client.

MichaelSolati avatar Apr 10 '25 18:04 MichaelSolati