haskell-vim-now
haskell-vim-now copied to clipboard
begriffs
do not upgrade packages automatically
It is not right to upgrade package without asking the user. We should use --no-upgrade option to apt-get.
Reading package lists... Done
Building dependency tree
Reading state information... Done
libcurl4-openssl-dev is already the newest version.
exuberant-ctags is already the newest version.
make is already the newest version.
par is already the newest version.
vim is already the newest version.
Suggested packages:
git-daemon-run git-daemon-sysvinit git-doc git-el git-email git-gui gitk git-arch git-cvs git-mediawiki git-svn
The following packages will be upgraded:
git
1 upgraded, 0 newly installed, 0 to remove and 136 not upgraded.
Need to get 3262 kB of archives.
We should not install them in the first place =)
As I said before: one-liner is great, but totally not secure. Maybe we could move packages installation to a separate script? Or even remove it completely and add a requirements section in README?
Maybe have the installer check for the packages and die with a helpful error if they are not there. However we already have the functionality implemented for installing the packages, and it does make the installer really easy to use... The main premise of this project is that "one command later you have a Haskell IDE."
@harendra-kumar could you send a pull request to at least prevent unintentionally package upgrades?
One alternative is to ask the user to proceed or not when installation is required.
I sent a pull request to fix it for debian/apt-get. Not sure about brew/dnf/yum as I do not use those.