angular-paginate-anything icon indicating copy to clipboard operation
angular-paginate-anything copied to clipboard

Published 20 hours ago • verified publisher icon begriffs

Passive paginator doesn't update when url changes or reloadPage is set

Open sbleon opened this issue 10 years ago • 10 comments

Thanks for the great tool!

The passive copy at the bottom of my page doesn't update when url changes or when reloadPage is set. The active one works fine.

I tried to plunkr this, but I can't even see the passive copy on plunkr for some reason. I'll create another issue about that.

sbleon avatar Mar 03 '15 21:03 sbleon

Perhaps this will be fixed when #63 is resolved.

begriffs avatar Mar 12 '15 09:03 begriffs

My fork undoes the commit mentioned in #63 and this issue is not resolved when using said fork.

sbleon avatar Mar 12 '15 17:03 sbleon

Can you try again with v4.1.0?

begriffs avatar Mar 23 '15 03:03 begriffs

I don't see any change in behavior with v4.1.0.

sbleon avatar Mar 26 '15 14:03 sbleon

Can you demonstrate the problem with a plunkr?

begriffs avatar Apr 11 '15 16:04 begriffs

http://plnkr.co/edit/007mVhenNIdjAftfMW6K?p=preview demonstrates that if you change the perPage (via the dropdown) the passive copy doesn't update its page count. E.g. change perPage from 5 to 10 and see that the last page in the passive copy stays at 47,178. I think this is the same issue that I was trying to report.

sbleon avatar Apr 14 '15 15:04 sbleon

Ah I totally see what you mean. I'll try to create a regression test and investigate a fix.

begriffs avatar Apr 14 '15 15:04 begriffs

Thanks!

On Tue, Apr 14, 2015 at 11:48 AM, Joe Nelson [email protected] wrote:

Ah I totally see what you mean. I'll try to create a regression test and investigate a fix.

Reply to this email directly or view it on GitHub https://github.com/begriffs/angular-paginate-anything/issues/62#issuecomment-92921041 .

sbleon avatar Apr 14 '15 15:04 sbleon

I just spent some time debugging and I really don't know why this is happening. Maybe a quirk about how directive binding works when sharing a variable in the parent scope? Then again other shared variables like the page number seem to work fine.

begriffs avatar Apr 25 '15 17:04 begriffs

Thanks for looking into it! I'm not using the passive copy any more because of this issue, and I'm OK without it for the time being.

It's probably one of those $apply() things that I feel like I'll never understand!

On Sat, Apr 25, 2015 at 1:20 PM, Joe Nelson [email protected] wrote:

I just spent some time debugging and I really don't know why this is happening. Maybe a quirk about how directive binding works when sharing a variable in the parent scope? Then again other shared variables like the page number seem to work fine.

Reply to this email directly or view it on GitHub https://github.com/begriffs/angular-paginate-anything/issues/62#issuecomment-96240724 .

sbleon avatar Apr 27 '15 15:04 sbleon