beefore icon indicating copy to clipboard operation
beefore copied to clipboard

Pip --outdated ran as check

Open mattions opened this issue 8 years ago • 2 comments

I was wondering if there is the possibility to add to the check something like

pip list --outdated

and fail the check if new packages have been updated. Maybe we need some kind of flexibility, so we want to pass a certain amount of packages with versions that could be skipped?

Just a thoughts.

mattions avatar Jan 25 '17 11:01 mattions

Definitely sounds like an interesting idea that is worth having at some level.

However, I'm not sure if this is appropriate as a pre-review check, or a pre-commit check. For example: You submit a patch that adds feature X or fixes bug Y; BeeFore runs and raises an error because package Z needs to be updated. The fact that package Z needs to be updated is (probably) unrelated to the X or Y, and from a change management point of view, any fixes required by updating Z shouldn't be included in the same commit as the X/Y PR.

This is definitely something that should be reported, though - a simple lack of awareness that dependencies have updates pending is worth flagging. In fact, whenever a dependency is updated, the test suite should be executed again to verify that the code still works - if it doesn't, a bug should be opened to either constrain the version dependency, or update the code to handle the change.

freakboy3742 avatar Jan 26 '17 01:01 freakboy3742

@freakboy3742 I agree.

TBH I would like to have the run in any commit, as part of my test-suite. If there is a PR, and the dependencies are not up to date, it would be cool to have something that:

  • branch off master
  • update the requirements to latest
  • test suite runs automatically
  • propose PR

Maybe a service that check this stuff would be good, but as a start it could be done just before the test-suite, or whenever beefore would be ran.

mattions avatar Jan 26 '17 08:01 mattions