fritter icon indicating copy to clipboard operation
fritter copied to clipboard

Getting notifications meant for others

Open vuldin opened this issue 7 years ago • 8 comments

fritter-notifications Clicking on 'Notifications' shows me three notifications from Andre Staltz for three different posts by Tim Caswell. I'm currently following Andre but not (yet) Tim, and I haven't interacted with those posts in any before seeing them in my Notifications.

vuldin avatar Jan 12 '18 23:01 vuldin

I've seen this myself. Seems like in some cases the notifications index gets built without having the user's id set, causing this.

pfrazee avatar Jan 12 '18 23:01 pfrazee

Same happened to me, had to manually remove the notifications. What's interesting is that these were the same three posts 🤔

alterx avatar Jan 13 '18 15:01 alterx

Same just happened to me...

screen shot 2018-05-05 at 07 31 54

The data in Tara's post looks OK

{
  "text": "Check it out y'all, we finally have mentions on here thanks to @Sander ! ",
  "createdAt": 1525403903948,
  "mentions": [
    {
      "name": "Sander",
      "url": "dat://14e02bfbe6d66113327a1e2f473dcd639dc3d9d97a05c1e5778a6c295fd02095"
    }
  ]
}

I don't see anything obvious in the libfritter code...

paul90 avatar May 05 '18 07:05 paul90

I've narrowed it down to a problem in

  function isAMentionOfUser (record) {
    return record.hasOwnProperty('mentions') && record.mentions.find(x => {
      return x.url == inst.userUrl
    })
}

it looks as if the value returned from the function in the find is not available. The response from record.mentions.find(x => { return x.url == inst.userUrl }) appears to be undefined, rather than true or false.

paul90 avatar May 05 '18 11:05 paul90

There is a note in https://github.com/beakerbrowser/libfritter/pull/4 on what was happening, and how the fix works.

paul90 avatar May 05 '18 14:05 paul90

Ok I think we've solved this. Fingers crossed.

pfrazee avatar May 05 '18 17:05 pfrazee

Thanks @paul90

pfrazee avatar May 05 '18 17:05 pfrazee

I created a new profile to give Fritter another go yesterday, and the same thing happened to me:

fritter-notifications-bug

I've been seeding Fritter for a while, so maybe I'm still using an older version. The most recently update seems to be from June, and the url is dat://9900f9aad4d6e79e0beb1c46333852b99829e4dfcdfa9b690eeeab3c367c1b9a.

Edit: Aha, just noticed in the settings screen it says "Fritter build 2018.06.14"

brechtcs avatar Nov 10 '18 11:11 brechtcs