modular-avatar
modular-avatar copied to clipboard
Consider making AnimationServicesContext public
Use cases:
- https://github.com/enitimeago/make-it-mmd/pull/64
- Others?
The class itself seems safe for making public, since using it is as straightforward as
seq.WithRequiredExtension(typeof(AnimationServicesContext), _ =>
{
seq.Run(MyPass.Instance); // does renames on GameObjects, animations get automagically handled
});
I haven't used AnimationDatabase and PathMappings directly, so I don't have an opinion on these properties in AnimationServicesContext.
(This is possibly more suited for NDMF? Merge this with https://github.com/bdunderscore/ndmf/issues/111?)
The main issue is I do plan on revisiting the internals of this in order to improve merge animator performance; I’m not sure if that would impact the semantics of this. So making this public might have to wait until I know what I’ll be doing there - but feel free to copy it into your project in the meantime.
Obsoleted by NDMF 1.7.x (#1371)?