Bradley Dice comments

Results 467 comments of


                                            Bradley Dice

Replace usages of `thrust::optional` with `std::optional`

/ok to test

Replace usages of `thrust::optional` with `std::optional`

/ok to test

Replace usages of `thrust::optional` with `std::optional`

@miscco Looks like there are legitimate test failures: ``` [ RUN ] TransformTest.IsNull /opt/conda/conda-bld/work/cpp/tests/utilities/column_utilities.cu:262: Failure Expected equality of these values: lhs.null_count() Which is: 0 rhs.null_count() Which is: 4 Google Test...

Replace usages of `thrust::optional` with `std::optional`

Thanks for the analysis @davidwendt. Should we consider merging all the changes _except_ those in `cpp/include/cudf/ast/detail/operators.hpp` for now? Or do we think this error is a showstopper for adoption of...

Replace usages of `thrust::optional` with `std::optional`

Since @miscco said he doesn't have bandwidth to finish this PR right now, I am planning to push some changes (reverting changes in AST code paths) that will let us...

Replace usages of `thrust::optional` with `std::optional`

@davidwendt Tests are passing for me locally as of 0418c91. I opened https://github.com/rapidsai/cudf/pull/16604 to explore the possibility of removing an optional from the AST code paths. I will also use...

Replace usages of `thrust::optional` with `std::optional`

@davidwendt Could you review again? Or can I dismiss your request for changes? I think this will be ready to go once we rerun the Java CI (it failed, but...

Replace usages of `thrust::optional` with `std::optional`

/merge

Replace usages of `thrust::optional` with `std::optional`

Thanks @miscco and reviewers!

Fix inconsistent usage of 'results' and 'records' in read-json.md

/ok to test