Bret Comnes

Results 345 comments of Bret Comnes

We did a code walkthrough together the other day. I think we can get this added fairly soon. I'll take a stab at it when I have time.

@keiko713 there is, but we can maybe pair and talk about it when I (or whoever does this) needs the information and form a specific question.

Ok, catching up on this. A few caveats/edge cases: - The buildbot clones the LFS backed repo down, without the LFS media swapped in place for the file pointers. -...

So solve the above mentioned edge case we would need to: - Swap LFS files during CLI deploys for LFS pointer files - Upload new assets that haven't made it...

I tried that, but with the old regex. So close! 😭

We could also fix https://github.com/hypermodules/choo-location-electron to work with the new sheet router / choo. Things works pretty well using that arrangement.

Switched to using nanorouter and hashes. Works great. Good to close.

> What I do not understand is why the `.signature` part is still there. We are getting it from fastify-cookie and cookie-signature.. and the signature part should have already be...

> so I'm 100% confident master builds and runs Perhaps it's environmental? afaict, homebrew has changed the location openssl is installed which hoses the current build process.

Probably wouldn't be hard to do. I tend to just publish those though. You can link them from the README to make it more discoverable. Not a bad best practice,...