signal-cli-rest-api icon indicating copy to clipboard operation
signal-cli-rest-api copied to clipboard

Corrected for JVM crash by using more robust LTS JRE base image

Open hillct opened this issue 10 months ago • 1 comments

Corrected for JVM crash by using more robust LTS JRE base image, saving 200MB in final image size as a bonus. This work was done in an attempt to address https://github.com/bbernhard/signal-cli-rest-api/issues/651 which it does not do completely, but the enhancements to the Dockerfile are generally beneficial in that they increase build predictability by shifting to the LTS OpenJRE image.

This has not been tested across all supported platform as I don't have any arm7 hardware with which to test. It should be noted that arm7 continues to utilize the old Jammy image, so it should be fine anyway.

hillct avatar Feb 08 '25 19:02 hillct

I really appreciate the effort you put into this! However, I am a bit worried that having two different base images will increase the maintenance burden significantly. I had something like this in the early stages of this project and it was a bit of a pain to maintain and resulted in some subtle bugs. :/

I asked the eclipse-temurin guys a while ago whether they can re-enable the armv7 builds and I think there were also some active discussions about that, but I am not sure if there was actually some progress there. Need to look up that issue in their issue tracker.

That being said, I would definitely be more comfortable, if there would just be one base image for all the supported architectures. But I'll think about it a bit more.

bbernhard avatar Feb 08 '25 20:02 bbernhard

Wow, amazing work @hillct 🚀

reneleonhardt avatar May 20 '25 10:05 reneleonhardt