react-transcript-editor icon indicating copy to clipboard operation
react-transcript-editor copied to clipboard

Published 20 hours ago • verified publisher icon bbc

Improve performance

Open mitchell-bu opened this issue 5 years ago • 0 comments

Is your Pull Request request related to another issue in this repository ?
https://github.com/bbc/react-transcript-editor/issues/218

Describe what the PR does
This adds a new property to the editors, handleEditingComplete, that will fire when isEditable changes from true to false and includes the transcript as an argument. Also added a check if handleAutoSaveChanges is defined before calling it.

State whether the PR is ready for review or whether it needs extra work
Ready for review

Additional context
I'm honestly not familiar with how storybooks work. I tried adding this new property to the demo app, but didn't have much luck getting it to work. These changes have been pulled into a separate project and is working as expected there.

mitchell-bu avatar Jan 14 '20 17:01 mitchell-bu