react-transcript-editor icon indicating copy to clipboard operation
react-transcript-editor copied to clipboard

Progress bar bug on large screen

Open pietrop opened this issue 6 years ago • 3 comments

Describe the bug

The progress bar looks off on large screens (27-inch) - see screenshot

To Reproduce Steps to reproduce the behavior:

Load demo storybook app on a large screen, eg 27-inch

Expected behavior

For the progress bar to look the same on a larger screen.

Screenshots

bug-progress-bar

Additional context

NA

pietrop avatar Oct 04 '19 09:10 pietrop

is this what is causing the issue /packages/components/media-player/src/ProgressBar.module.scss#L3?

$slider-width-number: 1440;

is 1440 supposed to be a max screen width?

pietrop avatar Oct 07 '19 12:10 pietrop

Also, weirdly maybe unrelated - I'm seeing a gap in progress bar when progressing further into the video. Screen Shot 2019-10-07 at 13 37 32

emettely avatar Oct 07 '19 12:10 emettely

Interesting, I wasn't able to reproduce that @emettely

I did noticed tho that if I change slider-width-number to be 2290 then the problem is fixed (?) at least on a 27in screen.

$slider-width-number: 2290;

pietrop avatar Oct 07 '19 14:10 pietrop