rules_swift
rules_swift copied to clipboard
expose protoc-gen-grpc-swift as a gRPC generator
Up until now rules_swift only exposed protoc-gen-swiftgrpc, the 0.x gRPC generated for Swift. This PR adds support for the 1.x gRPC generator, protoc-gen-grpc-swift. protoc-gen-grpc-swift generates code that depends on GPRC and NIO, so most of the code in this PR is setting up builds for GRPC and NIO. Not sure if this needs to live in rules_swift, but it's good enough for now 🙂
Some remaining todos:
- [ ] Audit all of the additional builds to ensure they have their required dependencies (cross-reference w/ upstream builds)
- [ ] Create builds for CNIOWindows and CNIOLinux
- [x] Fix issue where generated
.grpc.swiftfiles can't compile because they don't import their accompanying.pb.swift - [x] Only compile the relevant set of support libraries (
SwiftGRPCforswiftgrpc,GRPC/NIOforgrpc-swift)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!