rules_swift icon indicating copy to clipboard operation
rules_swift copied to clipboard

expose protoc-gen-grpc-swift as a gRPC generator

Open crockeo opened this issue 4 years ago • 2 comments

Up until now rules_swift only exposed protoc-gen-swiftgrpc, the 0.x gRPC generated for Swift. This PR adds support for the 1.x gRPC generator, protoc-gen-grpc-swift. protoc-gen-grpc-swift generates code that depends on GPRC and NIO, so most of the code in this PR is setting up builds for GRPC and NIO. Not sure if this needs to live in rules_swift, but it's good enough for now 🙂

Some remaining todos:

  • [ ] Audit all of the additional builds to ensure they have their required dependencies (cross-reference w/ upstream builds)
  • [ ] Create builds for CNIOWindows and CNIOLinux
  • [x] Fix issue where generated .grpc.swift files can't compile because they don't import their accompanying .pb.swift
  • [x] Only compile the relevant set of support libraries (SwiftGRPC for swiftgrpc, GRPC/NIO for grpc-swift)

crockeo avatar Nov 05 '21 16:11 crockeo

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Nov 05 '21 16:11 google-cla[bot]

@googlebot I signed it!

crockeo avatar Nov 06 '21 05:11 crockeo