rules_swift icon indicating copy to clipboard operation
rules_swift copied to clipboard

Published 20 hours ago • verified publisher icon bazelbuild

Warning / error paths in Xcode 13 are absolute

Open keith opened this issue 4 years ago • 6 comments

This breaks IDE integrations. I imagine it's a Swift change that we should fix upstream, or workaround in the worker.

Related https://github.com/bazelbuild/tulsi/issues/262

keith avatar Aug 07 '21 16:08 keith

https://bugs.swift.org/browse/SR-15123

keith avatar Aug 26 '21 22:08 keith

@rsahara can you verify your case is the same as mine by building with --features=-swift.vfsoverlay (this will negatively impact build performance)

keith avatar Aug 27 '21 00:08 keith

@keith Yes, it's the same issue. I tested it just now:

  • --features=swift.vfsoverlay (our current config) -> absolute path & the error messages don't appear on the editor (Xcode13)
  • --features=-swift.vfsoverlay -> relative path & the error messages appear on the editor (Xcode13)

Thank you for reporting the problem.

rsahara avatar Aug 27 '21 06:08 rsahara

Thanks for checking, hopefully we can get somewhere on a fix

keith avatar Aug 27 '21 15:08 keith

I've submitted https://reviews.llvm.org/D109128, which does appear to fix the issue, but I'm not convinced it's the right fix, we'll see what feedback I get there

keith avatar Sep 02 '21 04:09 keith

My fix was merged into apple/llvm-project and I believe is slated to be in Swift 5.6. The Swift 5.5 backport has gotten no response

keith avatar Dec 03 '21 18:12 keith