rules_python icon indicating copy to clipboard operation
rules_python copied to clipboard

Add support for building universal wheels in the py_wheel rule.

Open awbraunstein opened this issue 4 years ago • 3 comments

🚀 feature request

Relevant Rules

This is a feature that should be added to the py_wheel rule.

-->

Description

I'd like the ability to build universal wheels to be added to the py_wheel rule. This should be relatively simple since it just requires passing the --universal flag when building the wheel.

Describe the solution you'd like

Add a new value for python_tag that is either universal or py2and3 that builds a universal wheel.

Describe alternatives you've considered

Building two wheels isn't as easy to distribute.

awbraunstein avatar Dec 21 '20 22:12 awbraunstein

It's probably best to change versions to be a list.

pstradomski avatar Dec 29 '20 13:12 pstradomski

Relevant PEPs:

  • https://www.python.org/dev/peps/pep-0427/#file-contents
  • https://www.python.org/dev/peps/pep-0425/#compressed-tag-sets

pstradomski avatar Dec 29 '20 15:12 pstradomski

It would be best to merge https://github.com/bazelbuild/rules_python/pull/388 first, to avoid conflicts

pstradomski avatar Dec 29 '20 15:12 pstradomski