rules_proto icon indicating copy to clipboard operation
rules_proto copied to clipboard

Published 20 hours ago • verified publisher icon bazelbuild

fix: rules_cc is not a dev_dependency

Open alexeagle opened this issue 1 year ago • 1 comments
trafficstars

Since the tools/file_concat program is written in C++ and exposed to users of proto_descriptor_set, we depend on rules_cc at runtime.

Fixes #203

alexeagle avatar May 02 '24 00:05 alexeagle

Ping @comius

alexeagle avatar May 02 '24 17:05 alexeagle

ping @comius

alexeagle avatar May 15 '24 00:05 alexeagle

ping @alexeagle

comius avatar May 23 '24 18:05 comius

Removed the comment - good to merge now?

alexeagle avatar May 23 '24 19:05 alexeagle

i missed this one and submitted with lockfile and workspace changes too https://github.com/bazelbuild/rules_proto/pull/215, doesn't matter which is merged but it would be nice to see 1 land

keith avatar May 28 '24 18:05 keith

@meteorcloudy could you merge please? I'm sad to start the precedent of BCR diverging from the repo it's published from, only because the former has active maintainers with commit access

alexeagle avatar May 29 '24 01:05 alexeagle

Closing as a duplicate of https://github.com/bazelbuild/rules_proto/pull/215

comius avatar May 29 '24 04:05 comius