rules_kotlin icon indicating copy to clipboard operation
rules_kotlin copied to clipboard

Remove bazel_tools android usage

Open keith opened this issue 1 year ago • 1 comments

This was removed with bazel 8.x and exists in rules_android now

keith avatar Oct 17 '24 18:10 keith

This complicates experimenting with Bazel 8.0rc1, and would presumably complicate migration once Bazel 8.0 is released. Would be great to see it merged some time before that happens (NET 2024-10-28)

mortenmj avatar Oct 21 '24 10:10 mortenmj

This complicates experimenting with Bazel 8.0rc1, and would presumably complicate migration once Bazel 8.0 is released. Would be great to see it merged some time before that happens (NET 2024-10-28)

It's breaking a few integration tests, including bazel 6.4. Will take a a minute to sort that.

ERROR: https://bcr.bazel.build/modules/rules_jvm_external/6.2/MODULE.bazel:93:13: name 'use_repo_rule' is not defined
Loading: 
ERROR: Error computing the main repository mapping: in module dependency chain <root> -> [email protected] -> [email protected]: error executing MODULE.bazel file for [email protected]
ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/sandbox/linux-sandbox/613/execroot/_main/_tmp/e8ec095c07b8eb8fe6326a99c602b1b8/_bazel_buildkite-agent/9d9df1d6447036986a9e38089c4dc229/external/rules_java~/java/common/proguard_spec_info.bzl:16:20: ProguardSpecProvider is experimental and thus unavailable with the current flags. It may be enabled by setting --experimental_google_legacy_api
WARNING: Target pattern parsing failed.

Which means, by merging, we require all users to --experimental_google_legacy_api at a certain point.

restingbull avatar Oct 21 '24 18:10 restingbull

Bazel 7.4.0 (or bazel 8) + the upcoming rules_android 0.6.0 release remove the need for --experimental_google_legacy_api (as discussed on various thread / issues, this is a problem for rules_jvm_external too and why https://github.com/bazel-contrib/rules_jvm_external/commit/ba7310ce4a1d8fb14434597fbc7440a4074f7695 was reverted in https://github.com/bazel-contrib/rules_jvm_external/pull/1215)

ahumesky avatar Oct 25 '24 20:10 ahumesky

@ahumesky do you have an ETA for rules_android 0.6.0?

nkoroste avatar Nov 01 '24 20:11 nkoroste

We're aiming for next week, https://github.com/bazelbuild/rules_android/commit/6bad08d0f0b10594f970527a3ae51e6ff3b15657 gets us very close. We have an in-progress change to make the Android rules work with Java 11. We believe the final issue is an http_jar in robolectric-bazel needs to be refactored

ahumesky avatar Nov 01 '24 22:11 ahumesky

Well, it turns out that getting latest rules_android + Bazel 8 + WORKSPACE to work is a pretty big quagmire. I started this issue to track the status: https://github.com/bazelbuild/rules_android/issues/278

Perhaps late this week or early next week we will have gotten through all the issues.

ahumesky avatar Nov 12 '24 23:11 ahumesky