rules_kotlin icon indicating copy to clipboard operation
rules_kotlin copied to clipboard

Published 20 hours ago • verified publisher icon bazelbuild

Relativize jar paths in jdeps and rework `BazelRunFiles` to return relative paths

Open arunkumar9t2 opened this issue 1 year ago • 2 comments

Fixes #941

We found that certain Kotlin versions, 1.8.10 for example can produce absolute paths in jdeps output. Although this is fixed in 1.8.20 (not sure which commit caused this on Kotlin side), this PR ensures jdeps jars always use relative path.

  • Added test to assert all jar paths in jdeps are relative
  • Updated test builder to use relative paths for assertions

arunkumar9t2 avatar Feb 28 '24 05:02 arunkumar9t2

Seems RBE is failing, will revisit.

arunkumar9t2 avatar Feb 28 '24 06:02 arunkumar9t2

@arunkumar9t2 PR looks good to me as long as you can take care of the RBE case.

Bencodes avatar Feb 29 '24 18:02 Bencodes