rules_foreign_cc icon indicating copy to clipboard operation
rules_foreign_cc copied to clipboard

Added foreign_cc_binary/library rule

Open UebelAndre opened this issue 4 years ago • 5 comments
trafficstars

UebelAndre avatar Jun 19 '21 03:06 UebelAndre

this looks great, was just thinking about trying something similar

zachgrayio avatar Jun 20 '21 23:06 zachgrayio

This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_foreign_cc!

github-actions[bot] avatar Dec 18 '21 22:12 github-actions[bot]

I'd be interested in reviving these rules. Even if they go in some sort of contrib or examples directory, I think there is value in them.

However, I do not feel very strongly about them since I've already sort-of implemented my own version. But I'd be happy to replace my home-grown rules with more "official" ones.

attilaolah avatar Dec 21 '21 09:12 attilaolah

This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_foreign_cc!

github-actions[bot] avatar Jun 19 '22 22:06 github-actions[bot]

Please don't close it just yet :)

attilaolah avatar Jun 20 '22 11:06 attilaolah

This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_foreign_cc!

github-actions[bot] avatar Dec 17 '22 22:12 github-actions[bot]

this seems to work a lot better than the runnable_files macro currently in main. do you think we could just replace that macro with this foreign_cc_binary impl?

pjjw avatar Dec 20 '22 23:12 pjjw

this seems to work a lot better than the runnable_files macro currently in main. do you think we could just replace that macro with this foreign_cc_binary impl?

I'd be happy to merge a PR that did that but I have no time to actually implement said PR; feel free to give it a go.

jsharpe avatar Jan 03 '23 11:01 jsharpe

I'm not working this. but someone anyone is free to revive it if they thought it'd be useful!

UebelAndre avatar Dec 25 '23 20:12 UebelAndre