rules_foreign_cc
rules_foreign_cc copied to clipboard
Added foreign_cc_binary/library rule
this looks great, was just thinking about trying something similar
This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_foreign_cc!
I'd be interested in reviving these rules. Even if they go in some sort of contrib or examples directory, I think there is value in them.
However, I do not feel very strongly about them since I've already sort-of implemented my own version. But I'd be happy to replace my home-grown rules with more "official" ones.
This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_foreign_cc!
Please don't close it just yet :)
This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_foreign_cc!
this seems to work a lot better than the runnable_files macro currently in main. do you think we could just replace that macro with this foreign_cc_binary impl?
this seems to work a lot better than the
runnable_filesmacro currently in main. do you think we could just replace that macro with thisforeign_cc_binaryimpl?
I'd be happy to merge a PR that did that but I have no time to actually implement said PR; feel free to give it a go.
I'm not working this. but someone anyone is free to revive it if they thought it'd be useful!