rules_closure icon indicating copy to clipboard operation
rules_closure copied to clipboard

Consider using buildifier

Open hochhaus opened this issue 9 years ago • 3 comments
trafficstars

As a feature request, rules_closure could consider using buildifier to format internal BUILD files.

https://github.com/bazelbuild/buildifier

hochhaus avatar Jun 24 '16 01:06 hochhaus

+1

I've already been using buildifier this whole time. It's integrated into emacs and eclipse internally at Google.

The question is: how do we enforce it in CI? Hey @damienmg there's no such thing as METADATA presubmits in the Bazel world. We obviously don't want to have a rule in every single one of our dozens of BUILD files to make them validate themselves. What do we do?

jart avatar Jun 24 '16 04:06 jart

The closest thing to our METADATA presubmit hooks would probably be the Git precommit hook.

davidzchen avatar Jun 27 '16 11:06 davidzchen

We will add this a test job to ci.bazel.io.

damienmg avatar Jun 27 '16 11:06 damienmg