rules_cc icon indicating copy to clipboard operation
rules_cc copied to clipboard

Move static library validation helper to `ar_files`

Open fmeum opened this issue 1 year ago • 1 comments
trafficstars

It doesn't need to be staged for every compile or link action. The action that uses it stages all_files.

fmeum avatar Oct 15 '24 12:10 fmeum

A local run of buildifier -lint=warn -r . doesn't show any findings, but the CI run fails (without output). Not sure what to do about that.

fmeum avatar Oct 15 '24 12:10 fmeum

This breaks cc_builtins tests. https://storage.googleapis.com/bazel-untrusted-buildkite-artifacts/01931ae7-07f8-4c6c-b4b2-c951a9ac7410/src/main/starlark/tests/builtins_bzl/cc_builtin_tests/test_attempts/attempt_1.log

comius avatar Nov 11 '24 13:11 comius

I'll take a look at some point, but it's not a high priority improvement.

fmeum avatar Nov 11 '24 15:11 fmeum