rules_apple icon indicating copy to clipboard operation
rules_apple copied to clipboard

Fix app intents with Xcode 15.3+

Open keith opened this issue 1 year ago • 4 comments

Depends on https://github.com/bazelbuild/rules_swift/pull/1170

keith avatar Feb 29 '24 00:02 keith

Has the time come at last?

pennig avatar May 20 '24 21:05 pennig

Yes, we just need a new rules_swift release I believe depending on when we're happy with the status of the cherry-picks there

BalestraPatrick avatar May 21 '24 22:05 BalestraPatrick

@BalestraPatrick can you update this to point to the rules_swift 2.0.0-rc1 release? I'm going to create a release without this change, which is compatible but doesn't require rules_swift 2.0, and then once that is out we can start depending on it in order to merge this?

brentleyjones avatar Jun 27 '24 14:06 brentleyjones

@brentleyjones Updated now. I also pushed a possible fix for one breaking change (target_name related), but there's another breaking change as expected for the symbol graph API which seems to be more involved since we need to switch to using the aspect instead (https://github.com/bazelbuild/rules_apple/issues/2445):

Error: 'struct' value has no field or method 'symbol_graph'

BalestraPatrick avatar Jun 28 '24 09:06 BalestraPatrick

@BalestraPatrick looks like this is validated on CI now https://github.com/bazelbuild/rules_apple/issues/2488

keith avatar Jul 08 '24 18:07 keith

I left a comment here: https://github.com/bazelbuild/rules_apple/issues/2488#issuecomment-2216991527

But it looks on rules_apple side we also need to fix the docc rules (https://github.com/bazelbuild/rules_apple/pull/2487) in order to bump to rules_swift 2.0.0 which is required for this PR to be merged.

BalestraPatrick avatar Jul 09 '24 08:07 BalestraPatrick

The failures are due to DocC rules needing to be updated for rules_swift 2.0, thats being done over in: #2487

The intents tests are passing though via:

bazel test //test/starlark_tests:ios_application

luispadron avatar Jul 09 '24 14:07 luispadron