rules_android icon indicating copy to clipboard operation
rules_android copied to clipboard

Migrate to Bzlmod for managing external dependencies

Open meteorcloudy opened this issue 2 years ago • 3 comments

With future Bazel LTS versions, Bzlmod will become the default system for external dependencies management.

Please consider migrating all your external dependencies in WORKSPACE to MODULE.bazel

For more information, please check https://github.com/bazelbuild/bazel/issues/18958

meteorcloudy avatar Oct 06 '23 13:10 meteorcloudy

https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/3352#018af627-f96d-4305-bb29-8af240ab7f95 Looks like only two tests failing:

//src/tools/javatests/com/google/devtools/build/android/sandboxedsdktoolbox/apidescriptors:ExtractApiDescriptorsCommandTest FAILED in 3 out of 3 in 0.4s
//src/tools/javatests/com/google/devtools/build/android/sandboxedsdktoolbox/sdkdependenciesmanifest:GenerateSdkDependenciesManifestCommandTest FAILED in 3 out of 3 in 0.5s

meteorcloudy avatar Oct 06 '23 14:10 meteorcloudy

We need to use the Java runfiles library at https://github.com/bazelbuild/rules_android/blob/5f969078a26aa472638b0c16f6c0e747dbb560f4/src/tools/javatests/com/google/devtools/build/android/sandboxedsdktoolbox/apidescriptors/ExtractApiDescriptorsCommandTest.java#L39-L42

meteorcloudy avatar Oct 06 '23 14:10 meteorcloudy

Hmm, I thought that all tests under //src/tools were being run in BazelCI already (which should include a bzlmod config): https://github.com/bazelbuild/rules_android/blob/main/.bazelci/presubmit.yml#L7

Curious that there would be tests failing still.

ted-xie avatar Oct 12 '23 15:10 ted-xie