intellij icon indicating copy to clipboard operation
intellij copied to clipboard

Add handling in aspect for implementation_deps

Open sfc-gh-abalik opened this issue 2 years ago • 6 comments

Checklist

  • [x] I have filed an issue about this change and discussed potential changes with the maintainers.
  • [x] I have received the approval from the maintainers to make this change.
  • [x] This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See the Contributions section in the README for more details.

Discussion thread for this change

Issue number: https://github.com/bazelbuild/intellij/issues/5149

Description of this change

Update the aspect to

  • Propagate along implementation_deps
  • Collect includes/defines from a target's implementation_deps

These changes are needed to enable intellisense, go to definition, etc in CLion for files that belong to targets using implementation_deps.

sfc-gh-abalik avatar Aug 08 '23 22:08 sfc-gh-abalik

@tpasternak would you be able to take a look at this?

sfc-gh-abalik avatar Aug 22 '23 21:08 sfc-gh-abalik

I'm not sure if I understand the whole idea of implementation_deps correctly, but for me it looks like a bug inside bazel. The data from implementation_deps should already be available in compilation_context

cc @ujohnny

tpasternak avatar Sep 28 '23 13:09 tpasternak

https://github.com/bazelbuild/bazel/issues/19663

tpasternak avatar Sep 28 '23 13:09 tpasternak

Is this expected to be merged? At this time implementation_deps is unusable when developing with CLion

dieortin avatar Oct 10 '24 08:10 dieortin

@ujohnny @LeFrosch as the Bazel team rejected to fix that on their side, I think we should accept the change. WDYT?

tpasternak avatar Oct 15 '24 16:10 tpasternak

@tpasternak I can check it on Friday

LeFrosch avatar Oct 16 '24 08:10 LeFrosch

Closing since a similar fix was made in https://github.com/bazelbuild/intellij/pull/6919.

sfc-gh-abalik avatar Nov 05 '24 16:11 sfc-gh-abalik