intellij
intellij copied to clipboard
Add handling in aspect for implementation_deps
Checklist
- [x] I have filed an issue about this change and discussed potential changes with the maintainers.
- [x] I have received the approval from the maintainers to make this change.
- [x] This is not a stylistic, refactoring, or cleanup change.
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See the Contributions section in the README for more details.
Discussion thread for this change
Issue number: https://github.com/bazelbuild/intellij/issues/5149
Description of this change
Update the aspect to
- Propagate along
implementation_deps - Collect includes/defines from a target's
implementation_deps
These changes are needed to enable intellisense, go to definition, etc in CLion for files that belong to targets using implementation_deps.
@tpasternak would you be able to take a look at this?
I'm not sure if I understand the whole idea of implementation_deps correctly, but for me it looks like a bug inside bazel. The data from implementation_deps should already be available in compilation_context
cc @ujohnny
https://github.com/bazelbuild/bazel/issues/19663
Is this expected to be merged? At this time implementation_deps is unusable when developing with CLion
@ujohnny @LeFrosch as the Bazel team rejected to fix that on their side, I think we should accept the change. WDYT?
@tpasternak I can check it on Friday
Closing since a similar fix was made in https://github.com/bazelbuild/intellij/pull/6919.