bazel icon indicating copy to clipboard operation
bazel copied to clipboard

refactor: allow relative symlinks that points out of the treeartifact

Open thesayyn opened this issue 1 year ago • 4 comments
trafficstars

Fixes https://github.com/bazelbuild/bazel/issues/20891

thesayyn avatar Feb 08 '24 19:02 thesayyn

cc @tjgq @comius

thesayyn avatar Feb 08 '24 19:02 thesayyn

cc @tjgq @comius

Thanks. I believe @tjgq is more qualified reviewer in this case.

comius avatar Feb 09 '24 07:02 comius

df07d275ce17f14224af0f1a5862755a7db44397 touched some code around this area, so you'll have to rebase your PR.

tjgq avatar Feb 14 '24 12:02 tjgq

All right. I'll get to it soon hopefully.

thesayyn avatar Feb 14 '24 18:02 thesayyn

@tjgq dangling symlinks isn't seem to be supported anymore. is that expected? i get tests failing with "is a dangling symbolic link"

thesayyn avatar Feb 20 '24 05:02 thesayyn

Also would it be possible to cherry pick this into 7.1.0? We'd like to start rolling this out with rules_oci as soon as we can.

thesayyn avatar Feb 20 '24 05:02 thesayyn

@tjgq Ready for another pass.

thesayyn avatar Feb 20 '24 05:02 thesayyn

@bazel-io fork 7.1.0

tjgq avatar Feb 20 '24 13:02 tjgq