bazel icon indicating copy to clipboard operation
bazel copied to clipboard

Emit LLVM coverage for source file paths with a `tmp` segment

Open fmeum opened this issue 3 years ago • 2 comments

The LLVM LCOV coverage collection logic attempted to filter out source files under /tmp/, but instead filtered out all source files with paths containing the substring /tmp/. Under macOS, where Bazel's output base lies under /private/var/tmp, this matched every output base absolute path.

fmeum avatar Nov 25 '22 12:11 fmeum

@c-mita Could you review this PR?

fmeum avatar Nov 25 '22 12:11 fmeum

@c-mita Friendly ping

fmeum avatar Dec 09 '22 14:12 fmeum

@c-mita @sgowroji Friendly ping, does this need to be transitioned to "awaiting-merge"?

fmeum avatar Jan 03 '23 11:01 fmeum

Hello @c-mita, Can you please confirm to import the above PR changes.

sgowroji avatar Jan 03 '23 13:01 sgowroji

Oops. Yes, this should be imported.

c-mita avatar Jan 09 '23 14:01 c-mita

@bazel-io flag

fmeum avatar Jan 09 '23 14:01 fmeum

@bazel-io fork 6.1.0

ShreeM01 avatar Jan 18 '23 19:01 ShreeM01