bazel
bazel copied to clipboard
Add tool name for objcopy
It is not clear to me why this constant is in src/main/starlark/builtins_bzl/common/cc/action_names.bzl but not in tools/build_defs/cc/action_names.bzl, but it makes get_tool_for_action really annoying.
Furthermore, it seems that if we are willing to define llvm-cov for everyone we should do the same for objcopy.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
Following up on this, is there a reason we have no action name associated with objdump? That means you can't use get_tool_for_action to get the objdump tool and need to use the apparently-deprecated (per https://bazel.build/configure/integrate-cpp#generate-command-lines-toolchain) tool-specific getter. @comius would you mind if I added it?
Is the question related to: https://github.com/bazelbuild/bazel/issues/8438#issuecomment-1766793970 ?
If it is, it doesn't look like you need the action name in action_names.bzl.
In any case it should be fine to add the action name if you want it for the default toolchain.
I don’t mind if objdump is added