bazel icon indicating copy to clipboard operation
bazel copied to clipboard

Published 20 hours ago • verified publisher icon bazelbuild

Make CC_CODE_COVERAGE_SCRIPT failures fail tests

Open keith opened this issue 3 years ago • 15 comments
trafficstars

If you're editing, or overriding, this script and you introduce and introduce an error, previously this wouldn't fail the test invocation.

keith avatar May 09 '22 02:05 keith

there are CI failures

comius avatar Aug 26 '22 11:08 comius

Hi there! Thank you for contributing to the Bazel repository. We appreciate your time and effort. We're doing a clean up of old PRs and will be closing this one since it seems to have stalled. Please feel free to reopen/let us know if you’re still interested in pursuing this or if you'd like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so.

keertk avatar Dec 07 '22 19:12 keertk

@keertk can you reopen please

keith avatar Dec 07 '22 19:12 keith

Closing as another 2 months passed by. Feel free to reopen.

comius avatar Sep 25 '23 17:09 comius

we should really do this but fixing the existing tests is definitely annoying

keith avatar Oct 23 '23 19:10 keith

reopening with a opt-in env var to continue ignoring this failure meant only to avoid all the issues with bazel tests + CI setup (users should avoid this flag)

keith avatar Jan 09 '24 18:01 keith

@comius what do you think about this solution to avoid having to fix all the tests + CI runner setup

keith avatar Jan 10 '24 17:01 keith

@comius can you take a look?

keith avatar Jan 22 '24 19:01 keith

@comius can you take a look?

keith avatar Feb 16 '24 22:02 keith

@comius friendly ping

keith avatar May 16 '24 21:05 keith

ping @c-mita

comius avatar May 17 '24 03:05 comius

@c-mita can you take a look?

keith avatar Jun 04 '24 19:06 keith