bazel-watcher icon indicating copy to clipboard operation
bazel-watcher copied to clipboard

Publish the latest release to NPM

Open ashwin153 opened this issue 7 months ago • 7 comments

@chickenandpork @achew22 Would it be possible to publish the latest version (0.26.0) to NPM? I use bazel via npx run @bazel/ibazel, but it looks like the latest version on NPM is still 0.25.0. Thanks for all the hard work getting this project onto bzlmod!

ashwin153 avatar May 11 '25 03:05 ashwin153

I see that NPM release should be implicit with the release process: https://github.com/bazelbuild/bazel-watcher/blob/ffb6502dace574a88714d4f33666cbb3808906a1/.github/workflows/release.yaml#L84

Unsure why it didn’t trigger.

We could separate these release actions as independent so taphat the release can be re-triggered if it failed. Unsure how else to address. @achew22 ?

chickenandpork avatar May 11 '25 22:05 chickenandpork

It appears the release did trigger (click Actions, then filter by Build Release Binaries on the right hand side). The run that failed had a failed build step with the output:

Current runner version: '2.323.0'
Operating System
Runner Image
Runner Image Provisioner
GITHUB_TOKEN Permissions
Secret source: Actions
Prepare workflow directory
Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@3df4ab11eba7bda603[2](https://github.com/bazelbuild/bazel-watcher/actions/runs/14561912040/job/40846259746#step:1:2)a0b82a6bb43b11571feac' (SHA:3df4ab11eba7bda[6](https://github.com/bazelbuild/bazel-watcher/actions/runs/14561912040/job/40846259746#step:1:7)032a0b82a6bb43b[11](https://github.com/bazelbuild/bazel-watcher/actions/runs/14561912040/job/40846259746#step:1:13)571feac)
Error: Missing download info for actions/upload-artifact@v3

I have followed the upgrade guide in a PR and I'll trigger another release once that merges.

achew22 avatar May 12 '25 00:05 achew22

https://www.npmjs.com/package/@bazel/ibazel

I'm still seeing 0.25.0 as the latest release on NPM FWIW.

ashwin153 avatar May 12 '25 13:05 ashwin153

https://github.com/bazelbuild/bazel-watcher/actions/runs/14961483548

seems like the mac build failed.

ashwin153 avatar May 12 '25 15:05 ashwin153

Why is it even running a darwin amd64 build? Wouldn't we only need to build arm64 images for darwin? build (darwin_amd64, ibazel_darwin_amd64

ashwin153 avatar May 12 '25 15:05 ashwin153

Why is it even running a darwin amd64 build? Wouldn't we only need to build arm64 images for darwin? build (darwin_amd64, ibazel_darwin_amd64

I can’t be the only guy still using Intel Macs long after they’re “vintage”: I build on intel and arm. Just because they’re out of support doesn’t mean they disappear :)

I can take a look at the build failure, maybe help it. I didn’t check the build failure info because I don’t use npm, figured I wouldn’t know enough to help.

chickenandpork avatar May 12 '25 17:05 chickenandpork

Why is it even running a darwin amd64 build? Wouldn't we only need to build arm64 images for darwin? build (darwin_amd64, ibazel_darwin_amd64

... I can take a look at the build failure, maybe help it. I didn’t check the build failure info because I don’t use npm, figured I wouldn’t know enough to help.

... an of course it build just fine on a native MacOS box:

Allans-x86:bazel-watcher allanc$ uname -a
Darwin Allans-x86.local 24.4.0 Darwin Kernel Version 24.4.0: Fri Apr 11 18:28:23 PDT 2025; root:xnu-11417.101.15~117/RELEASE_X86_64 x86_64
Allans-x86:bazel-watcher allanc$ git log -n 1
commit 394b05ead6872960d3f6cf89f505fa63f82446bd (HEAD, upstream/master)
Author: Andrew Z Allen <[email protected]>
Date:   Sun May 11 18:51:41 2025 -0600

    Upgrade to latest versions of github actions packages (#736)
Allans-x86:bazel-watcher allanc$ bazel build //cmd/ibazel:ibazel --config release --platforms=@io_bazel_rules_go//go/toolchain:darwin_amd64_cgo 
Starting local Bazel server and connecting to it...
INFO: Invocation ID: 66b9d78c-65e8-4986-afd6-49f116933a4d
INFO: Analyzed target //cmd/ibazel:ibazel (127 packages loaded, 11005 targets configured).
INFO: Found 1 target...
INFO: From GoCompilePkg external/com_github_fsnotify_fsevents/fsevents.a:
cgo-gcc-prolog:452:2: warning: 'FSEventStreamScheduleWithRunLoop' is deprecated: first deprecated in macOS 13.0 - Use FSEventStreamSetDispatchQueue instead. [-Wdeprecated-declarations]
  452 |         FSEventStreamScheduleWithRunLoop(_cgo_a->p0, _cgo_a->p1, _cgo_a->p2);
      |         ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.4.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/FSEvents.framework/Headers/FSEvents.h:1154:1: note: 'FSEventStreamScheduleWithRunLoop' has been explicitly marked deprecated here
 1154 | FSEventStreamScheduleWithRunLoop(
      | ^
1 warning generated.
INFO: From GoLink cmd/ibazel/ibazel_/ibazel:
ld: warning: -no_pie is deprecated when targeting new OS versions
Target //cmd/ibazel:ibazel up-to-date:
  bazel-bin/cmd/ibazel/ibazel_/ibazel
INFO: Elapsed time: 56.484s, Critical Path: 7.18s
INFO: 121 processes: 111 remote cache hit, 10 internal.
INFO: Build completed successfully, 121 total actions
Allans-x86:bazel-watcher allanc$

I notice that the build log starts going askew at line 4: (https://github.com/bazelbuild/bazel-watcher/actions/runs/14961483548/job/42024200122#step:3:5 -- it subtly underlines the "4" line-number)

2025/05/12 00:56:18 Downloading https://releases.bazel.build/6.5.0/release/bazel-6.5.0-darwin-arm64...
Extracting Bazel installation...

The next "arm != amd" happens at line 581, but it seems to be just a generated path at that point.

At like 586, building for macOS-x86_64 but attempting to link with file built for unknown-arm64 looks like it leads to the error.

This suggests that the build containers -- still running macOS-14.7.5 (released recently, 2025-03-31, likely safe-ish but not the latest: 15.4.1) seem to be pulling in the arm bazel, and that may be tainting the later link stage.

chickenandpork avatar May 12 '25 18:05 chickenandpork

Stale issue message

github-actions[bot] avatar Jul 12 '25 02:07 github-actions[bot]

This has not been addressed. Not sure why this has been closed

alan-agius4 avatar Aug 25 '25 10:08 alan-agius4

NPM publishing via CI has been fixed and the new version has been published to NPM.

josephperrott avatar Aug 25 '25 15:08 josephperrott