laravel-wallet icon indicating copy to clipboard operation
laravel-wallet copied to clipboard

bug: DB::rollBack(0) in nova action prevents actionable trait to works

Open ibrunotome opened this issue 3 years ago • 1 comments

Describe the bug There is a Actionable trait that logs all actions that ran before

https://nova.laravel.com/docs/4.0/actions/defining-actions.html#action-log

Screen Shot 2022-09-13 at 11 48 40

But using the solution https://bavix.github.io/laravel-wallet/#/nova-action, these action logs will not be recorded

Server:

  • php version: 8.1
  • database: postgres 14.0
  • wallet version 9.3
  • cache lock: redis
  • cache wallets: redis

ibrunotome avatar Sep 13 '22 14:09 ibrunotome

@ibrunotome Thank you. I have never used this functionality. In the near future we will have to see what can be done there. At the moment, there are no ideas.

rez1dent3 avatar Sep 13 '22 16:09 rez1dent3

@ibrunotome Hello. Taylor accepted my PR and soon I will try to solve this problem and completely abandon my own DatabaseServiceInterface in favor of a standard solution.

But there will definitely not be a release in the near future, because. the changes are too big and you need to make sure that it works correctly.

Now you can take the event-architecture branch and see if your problem is gone.

PS. Changes to illuminate/database are still without a tag, so Laravel must be installed with the 9.x branch...

rez1dent3 avatar Oct 19 '22 18:10 rez1dent3

@ibrunotome Hello. Tag 9.6.0.

rez1dent3 avatar Oct 27 '22 17:10 rez1dent3

You're a great developer @rez1dent3, thank you for always being improving this package.

ibrunotome avatar Oct 28 '22 10:10 ibrunotome