laravel-wallet icon indicating copy to clipboard operation
laravel-wallet copied to clipboard

[10?] Currency commodity

Open rez1dent3 opened this issue 3 years ago • 2 comments

At the moment, the development of this functionality is frozen. I'm not clear who needs this functionality.

The functionality of currencies for goods is necessary for currency wallets. A product can be sold in dollars and there is a need to buy it with a euro wallet. Prior to this functionality, the developer had to check the correctness of the payment himself. I was often written that the purchase does not take into account the currency and the goods are bought one to one. For example, if the goods cost one hundred yuan, and the dollar purse, the owner of the wallet will pay one hundred dollars.


Everything would be fine, but this approach has its drawbacks - the return of goods. When returning an item, we must refund the cost, but important data is lost when converting currencies. Perhaps this problem will prevent me from releasing this functionality.

Now I am architecturally working on all possible options and I think that there is a need to use meta-data for the purchase. You pay with your wallet and we supplement the meta-data with the exchange rate, cost, currency and other data. The disadvantage of this approach is the limitation in the possibilities of meta-information.

rez1dent3 avatar May 17 '22 20:05 rez1dent3

Codecov Report

Merging #505 (e60e78c) into master (bc1e8bd) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head e60e78c differs from pull request most recent head 4cdb9de. Consider uploading reports for the commit 4cdb9de to get more accurate results

@@             Coverage Diff             @@
##              master      #505   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
+ Complexity       453       445    -8     
===========================================
  Files             72        72           
  Lines           1378      1370    -8     
===========================================
- Hits            1378      1370    -8     
Impacted Files Coverage Δ
src/Services/PurchaseService.php 100.00% <ø> (ø)
src/External/Dto/Cost.php 100.00% <100.00%> (ø)
src/Internal/Assembler/CostDtoAssembler.php 100.00% <100.00%> (ø)
src/Internal/Dto/ItemDto.php 100.00% <100.00%> (ø)
src/Objects/Cart.php 100.00% <100.00%> (ø)
src/Services/CastService.php 100.00% <100.00%> (ø)
src/Services/PrepareService.php 100.00% <100.00%> (ø)
src/Traits/CartPay.php 100.00% <100.00%> (ø)
src/WalletServiceProvider.php 100.00% <100.00%> (ø)
... and 35 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar May 17 '22 20:05 codecov[bot]

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4cdb9de
Status: ✅  Deploy successful!
Preview URL: https://4d65a1e6.laravel-wallet.pages.dev
Branch Preview URL: https://currency-commodity.laravel-wallet.pages.dev

View logs