ngx-webcam icon indicating copy to clipboard operation
ngx-webcam copied to clipboard

Adding event when the user accepts camera permissions

Open ivangarcia2 opened this issue 5 years ago • 1 comments

I added an event when the user accept camera persmissions. This event will be true if there are cameras in the system or false if there are not.

I believe this is interesting to better control user interface messages.

ivangarcia2 avatar Apr 06 '20 12:04 ivangarcia2

Hi @ivangarcia2, thanks for participating in this project! Looking at the diff, it seems like the new event emitter is triggered the same way as the existing cameraSwitched one - whenever a new camera stream is activated. This could be either initially when a user gave permissions, or when a user switched between cameras. It looks like the new event emitter is redundant, in which case I'd rather stick to the exiting one. Please let me know if I missed anything. Thanks!

For future reference, please keep file changes minimal and avoid reformatting existing code, this makes the diff harder to read.

basst314 avatar Dec 02 '21 22:12 basst314