Fathom icon indicating copy to clipboard operation
Fathom copied to clipboard

Unused parameters in diag2index and anti2index

Open ilaripih opened this issue 8 years ago • 1 comments
trafficstars

Hi,

Is there a reason why these two functions (defined here: https://github.com/basil00/Fathom/blob/master/src/tbprobe.c#L293) take two parameters but diag2index does nothing with d, and as a result anti2index does nothing with a? Actually, why does anti2index even exist if it's just a wrapper for diag2index with the same signature?

ilaripih avatar Dec 24 '16 07:12 ilaripih

Yes, I was wondering the same thing myself recently. The move generator code was written a long time ago, even pre-dating the Fathom project, so I am not sure. It is possible that they are just leftovers from earlier versions of the function.

basil00 avatar Dec 24 '16 15:12 basil00