Results 292 comments of Basil L. Contovounesios

> I guess this isn't the intended behavior I would hope not. > I am always hesitant before writing to any `private` variables from other libraries As you should be...

Sorry about the late reply. > I see from 3689c8f and #1611 that this fallback is supposed to work I've since forgotten the subtleties of #1611, so I may be...

> why should the code ever not consult the `t` fallback if there isn't a match? Unless I'm missing something, I think the fallback should only be consulted when sorting...

Thanks! > To continue in the same coding style as the others No need to worry about that. If you prefer to have such a command now, there's no need...

> This works fine if the test passes, but if it doesn't then the whole sexp [...] returns nil If I understood correctly, I think you just need to splice,...

> Happy to. Great! > I'll get on it. Thanks, just ping back here when the process is complete, or if you have any questions.

Thanks for working on this! > Should I expect some sort of confirmation of my CA, or am I good to go? I think we need to wait until you've...

See also #2501 and hlissner/doom-emacs#3686.

I understand, and I agree that what you describe is desirable behaviour. I only linked the other issues for some precedent on this (there's probably more, but I couldn't find...