django-easy-maps icon indicating copy to clipboard operation
django-easy-maps copied to clipboard

Assuming integer values for width/height

Open tombakas opened this issue 10 years ago • 7 comments

This prevents the users from entering percentages as values. Code from easy_maps/templatetags/easy_maps_tags.py:

...
options = Options(
        Argument('address', resolve=True, required=True),
        IntegerArgument('width', required=False, default=None),
        IntegerArgument('height', required=False, default=None),
        IntegerArgument('zoom', required=False, default=16),
        'using',
        Argument('template_name', default=None, required=False),
    )
...

I'd suggest turning these into Argument instances and adjusting the code in the html template accordingly.

tombakas avatar Oct 08 '15 09:10 tombakas

I had the same issue and downgraded easy_maps in order to keep maps ok in the responsive template

alexeiramone avatar Jul 04 '16 12:07 alexeiramone

Unfortunately, the project doesn't seem to be actively maintained.

On 4 July 2016 at 15:33, Alexei Martchenko [email protected] wrote:

I had the same issue and downgraded easy_maps in order to keep maps ok in the responsive template

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bashu/django-easy-maps/issues/53#issuecomment-230280201, or mute the thread https://github.com/notifications/unsubscribe/ABgcmc-3OVMLxzo-Jpvb-JcYGO8eV0qwks5qSP2BgaJpZM4GLNCm .

tombakas avatar Jul 04 '16 12:07 tombakas

@tombakas not sure if this need, all you need is to override / extend default easy_maps/map.html, for example https://github.com/bashu/django-easy-maps/blob/develop/example/templates/easy_maps/responsive.html

bashu avatar Oct 10 '16 10:10 bashu

@alexeiramone see comment above, let me know if this helps or not

bashu avatar Oct 10 '16 10:10 bashu

@tombakas @alexeiramone feel free to reopen if it's still an issue

bashu avatar Mar 29 '19 04:03 bashu

for some reason it's not working https://github.com/bashu/django-easy-maps/issues/53#issuecomment-252577441

aoulaa avatar Sep 07 '21 12:09 aoulaa

@aoulaa how it does not working? can you check updated responsive.html template

bashu avatar Oct 09 '21 06:10 bashu