Ben Ashbaugh comments

Results 432 comments of


                                            Ben Ashbaugh

Added semaphore test to cover out-of-order operations synchronized with barrier

Merging as discussed in the November 19th teleconference.

add SPIR-V 1.4 testing for UserSemantic

There are several issues in the SPIR-V LLVM Translator so these tests probably won't pass for most implementations currently, see: https://github.com/KhronosGroup/SPIRV-LLVM-Translator/issues/2460 https://github.com/KhronosGroup/SPIRV-LLVM-Translator/issues/2670 I'll keep this as a "draft" until these...

add SPIR-V 1.4 testing for UserSemantic

This should be ready for review now. I tested these tests with POCL and an up-to-date SPIR-V LLVM Translator and they both passed.

add SPIR-V 1.4 testing for UserSemantic

> LGTM (but needs a rebase) Yeah, I think I'm going to keep need to rebase these as the SPIR-V 1.4 changes are merged. There's probably a way I could...

add SPIR-V 1.4 testing for UserSemantic

I fixed the merge conflict in this PR and in #2122. I don't have a strong opinion which goes in first. If it's not this one though, I'll probably need...

add SPIR-V 1.4 testing for UserSemantic

Merging as per agreement in the October 29th teleconference.

Fix snorm

Can you please explain a bit more exactly what scenario this change is trying to fix? Does the problem happen when copying SNORM data from one image to the other?...

Fix snorm

Merging as discussed in the November 26th teleconference.

Fix updateMutableCommands template to use std::array::size() and const pointers

Could you add a test for this function? (It would have been good to do that previously, since it probably would have caught these bugs earlier.)

Fix updateMutableCommands template to use std::array::size() and const pointers

Fixed by #308 - closing.