typescript-book icon indicating copy to clipboard operation
typescript-book copied to clipboard

Published 20 hours ago • verified publisher icon basarat

Crazy interface exmaple does not compile

Open pjustino opened this issue 8 years ago • 4 comments

Hi Basarat, I notice that on the interfaces.md file the interface crazy could not be implemented in a class (please check here: https://github.com/Microsoft/TypeScript/issues/8917) and I made a fix with some text to explain better the pattern. I also fixed the constructor to not return any value as it seems not to be possible. Please check here: https://github.com/Microsoft/TypeScript/issues/11588

I tried to make a pull request but it seems I got no permissions.

pjustino avatar Aug 20 '17 23:08 pjustino

I tried to make a pull request but it seems I got no permissions.

You can make a PR. There is no way to block PRs on github so you do have permissions :rose:

basarat avatar Aug 21 '17 21:08 basarat

I used this command to push the commit: git push --set-upstream origin pjustino-interface-fix

I got this error: remote: Permission to basarat/typescript-book.git denied to pjustino. fatal: unable to access 'https://github.com/basarat/typescript-book.git/': The requested URL returned error: 403

Probably I'm doing something wrong can you please help

pjustino avatar Aug 21 '17 23:08 pjustino

unable to access 'https://github.com/basarat/typescript-book.git/': T

Your origin should be your fork :rose:

basarat avatar Aug 21 '17 23:08 basarat

thanks for the help. PR done

pjustino avatar Aug 22 '17 00:08 pjustino