laravel-dompdf icon indicating copy to clipboard operation
laravel-dompdf copied to clipboard

Fix config key for allowed protocols

Open willrowe opened this issue 2 years ago • 2 comments

dompdf expects camel case instead of snake case for this specific option as seen here.

willrowe avatar Nov 09 '23 19:11 willrowe

Look at here

angeljqv avatar Nov 10 '23 15:11 angeljqv

@angeljqv good to know. I guess this can be merged to allow compatible with older versions or the composer constraint should be bumped up once dompdf releases a new version with the change.

willrowe avatar Nov 10 '23 15:11 willrowe

Rest of the config is also snake_case

barryvdh avatar May 22 '24 08:05 barryvdh

@barryvdh understood, but just to be clear (and in case anyone else runs into this), since the options are passed through directly to Dompdf, the allowed_protocols key will have no effect when using any version of this library prior to v3.

Support for snake case was added in this PR: https://github.com/dompdf/dompdf/pull/3327 and then released in v3 of dompdf/dompdf.

willrowe avatar May 22 '24 13:05 willrowe

oh hmm, that's odd indeed.

barryvdh avatar May 22 '24 13:05 barryvdh