laravel-debugbar icon indicating copy to clipboard operation
laravel-debugbar copied to clipboard

Published 20 hours ago • verified publisher icon barryvdh

Provide an option to hide built-in routes from the list command

Open miken32 opened this issue 5 years ago • 4 comments

This resolves #1046 by overriding the built-in artisan route:list command to filter out the _debugbar routes. This functionality is enabled by a config flag, which is false by default.

miken32 avatar Oct 06 '20 17:10 miken32

Seems to fail some tests with Lumen. I don’t have any experience with that, and the tests aren’t giving any backtraces to see where the problem might be.

miken32 avatar Oct 07 '20 04:10 miken32

@barryvdh would an accept this PR, if I were to PR was complete with Lumen support ?

The reason I am asking, is because I made a PR towards @miken32 branch (which this PR uses) fixing the broken Lumen testing and I would love to get this merged :smiley:

sandervankasteel avatar Dec 14 '20 20:12 sandervankasteel

I'm sorta okay with this, but is this the proper way to extend it? Seems like there can be only one package to do this.

barryvdh avatar Dec 14 '20 21:12 barryvdh

I'm sorta okay with this, but is this the proper way to extend it? Seems like there can be only one package to do this.

Now that you mention it, I am unsure if this is the "proper way" to do it. I kinda assumed the original PR creator took this into consideration.

But since this PR is still in a state of "limbo", I will investigate this and get back to you on this (and if needed modify the code).

sandervankasteel avatar Dec 15 '20 09:12 sandervankasteel

Gonna hold off on this, doesn't feel totally right like this.

barryvdh avatar Feb 09 '24 16:02 barryvdh