node-scrypt icon indicating copy to clipboard operation
node-scrypt copied to clipboard

Incorrect 'N' for scrypt.hash

Open chrisveness opened this issue 9 years ago • 2 comments

It's taken me far longer for the penny to drop than it probably should have, but If I understand well, scrypt.hash is misinterpreting the N parameter.

In the params for scrypt.kdf, the N is actually logN – which while the naming is a little confusing, is much easier to work with than N itself, and I like.

However, in the params for scrypt.hash, the N parameter is actually N.

Hence scrypt.hash treats { N: 16, r: 8, p: 1} as if it were { N: 4, r: 8, p: 1}, resulting in a work factor of 16 instead of 65536.

chrisveness avatar Oct 17 '16 17:10 chrisveness

This is handled by https://github.com/barrysteyn/node-scrypt/pull/119

BrandonZacharie avatar Oct 19 '16 00:10 BrandonZacharie

Good stuff, thanks.

I'll close once the fix hits npm (so it doesn't get re-reported if anyone else hits it).

Excellent library, thanks for the work.

chrisveness avatar Oct 19 '16 09:10 chrisveness