cli53 icon indicating copy to clipboard operation
cli53 copied to clipboard

Upgrading aws-sdk-go and mikeg/dns

Open SeanSith opened this issue 1 year ago • 2 comments

Addresses #331 by upgrading the AWS SDK and mikeg/dns. Requires an update to Go 1.19.

@barnybug I could not get make test to run using Go 1.17 or 1.19 using make test. The failure is:

gucumber
panic: could not determine package path for internal/features/step_definitions.go

goroutine 1 [running]:
github.com/gucumber/gucumber.RunMain()
	/Users/ssmith/.go/pkg/mod/github.com/gucumber/[email protected]/run_main.go:42 +0x154
main.main()
	/Users/ssmith/.go/pkg/mod/github.com/gucumber/[email protected]/cmd/gucumber/gucumber.go:6 +0x20
make: *** [test-integration] Error 2

Please when making a pull request:

  • make sure changes are up to date with main.
  • please use brief, descriptive commit messages.
  • check code has been go formatted with 'go fmt'.
  • ensure you've added an integration test (under internal/features) or a unit test.
  • check the tests pass (make test).

cli53 has very good existing test coverage, so I'm unlikely to accept a pull request without a test, but please do ping me if you're struggling to add a test case and I'll help!

SeanSith avatar Nov 27 '23 20:11 SeanSith

Hi there, thanks for trying! As you may have seen the gucumber package we use for BDD is massively out of date with current Go but I've not found an easy path to getting it working without a big upheaval, so I'll have to hold off until I get some more time to look into this.

barnybug avatar Nov 28 '23 09:11 barnybug

Just wondering if there is any update on this, I am having a similar issue with aws sso credentials not working.

absmith82 avatar Aug 05 '24 19:08 absmith82