polaris_view_components icon indicating copy to clipboard operation
polaris_view_components copied to clipboard

Upgrade Polaris to v9.x

Open dan-gamble opened this issue 3 years ago • 1 comments

Ref #254

@kirillplatonov not sure if more is needed here?

I looked at a previous upgrade: https://github.com/baoagency/polaris_view_components/commit/a528179be4759e47c48afc77ab481743c890422a#diff-af5ce8b8edf3c6eebc227dadccb610b1e801b7a7f22a6359c5543b982e7151ba and there were some icon changes as well. I couldn't see any script that pulled the icons from anywhere so not sure if anything needs to be ran to do that?

dan-gamble avatar Jun 21 '22 16:06 dan-gamble

@dan-gamble yeah, few more things are required:

  1. Update icons. I just manually copied it from Polaris to our folder. They don't change frequently so it should be fine for now.
  2. Manually check all components in Lookbook and make sure they work correctly. Polaris v8-9 made a lot of breaking changes so 100% something will be broken during the upgrade.

kirillplatonov avatar Jun 22 '22 10:06 kirillplatonov

Closing in favor of #274

kirillplatonov avatar Dec 10 '22 08:12 kirillplatonov