react-native-image-resizer icon indicating copy to clipboard operation
react-native-image-resizer copied to clipboard

Published 20 hours ago • verified publisher icon bamlab

Updated the `generateFilePath()`

Open ulentini opened this issue 6 years ago • 4 comments

Updated the generateFilePath() method to accept paths on cache directory. It also generate new files on documents directory, to be consistent with the rest of the method behavior.

Discussion: #90

ulentini avatar Feb 28 '19 16:02 ulentini

Is this a breaking change?

Minishlink avatar Feb 28 '19 17:02 Minishlink

The only change that could be (maybe) considered breaking is the default directory used to store files. With this PR it changes from Cache directory to Document directory.

ulentini avatar Feb 28 '19 18:02 ulentini

Not generated valid path,when output path is not given in iOS,throwing error. Errors :- "line":200865,"column":48,"sourceURL":"/var/containers/Bundle/Application/D5C95D75-3BF0-40A3-BACB-A65854BF63DF/xxxxxxxx.app/main.jsbundle"

Biplovkumar avatar Mar 06 '19 17:03 Biplovkumar

@Biplovkumar I can't reproduce that error. I actually changed the default path to be in the Documents directory, instead of Cache directory. But this didn't lead to any error on my code, nor on the example app from this repo, that I just tried. Could you provide more info?

ulentini avatar Mar 09 '19 13:03 ulentini

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 01 '22 18:09 stale[bot]

This pull request has been automatically closed. Thank you for your contributions.

stale[bot] avatar Sep 08 '22 18:09 stale[bot]