ballerina-lang icon indicating copy to clipboard operation
ballerina-lang copied to clipboard

Published 20 hours ago • verified publisher icon ballerina-platform

[CLI IMPROVEMENT] improved cli message for new cmd

Open tanbirali opened this issue 1 year ago • 2 comments

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

Fixes #43428

Approach

Describe how you are implementing the solutions along with the design details. This is a Draft PR to understand if I am heading in the right direction.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • [x] Read the Contributing Guide
  • [ ] Updated Change Log
  • [ ] Checked Tooling Support (#<Issue Number>)
  • [ ] Added necessary tests
    • [ ] Unit Tests
    • [ ] Spec Conformance Tests
    • [ ] Integration Tests
    • [ ] Ballerina By Example Tests
  • [ ] Increased Test Coverage
  • [ ] Added necessary documentation
    • [ ] API documentation
    • [ ] Module documentation in Module.md files
    • [ ] Ballerina By Examples

tanbirali avatar Oct 08 '24 06:10 tanbirali

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 08 '24 06:10 CLAassistant

@tanbirali Thank you for the contribution. The changes you've made so far look great. Can you also address the rest of the changes to the bal new command, bal build and bal pack commands as mentioned in the issue? You will also have to fix the test cases related to these commands.

azinneera avatar Oct 08 '24 15:10 azinneera

You would encounter test failures in the ballerina-cli with these changes. Please change the output .txt files that are in https://github.com/ballerina-platform/ballerina-lang/blob/8ef9be112ff1bb02d8f647fb2aadced794417941/cli/ballerina-cli/src/test/resources/test-resources/command-outputs/ to reflect the changes.

E.g.

https://github.com/ballerina-platform/ballerina-lang/blob/8ef9be112ff1bb02d8f647fb2aadced794417941/cli/ballerina-cli/src/test/resources/test-resources/command-outputs/unix/build-empty-project-with-build-tools.txt#L8-L9

Change the above file as. Applies to other output files as well: https://github.com/ballerina-platform/ballerina-lang/blob/9276d9014adede8c8010f6b13eaf804371225fd7/cli/ballerina-cli/src/test/resources/test-resources/command-outputs/unix/build-empty-project-with-build-tools.txt#L8-L12

azinneera avatar Oct 31 '24 04:10 azinneera