Kevin Gibbons
Kevin Gibbons
> Use the same init between browser and node. There is nothing in the commit history that explains why the init is different, and it's not at all obvious why...
> No matter how i init it, i can't get it to try to load the z3-built script or wasm piece twice. It's not that it would load the script...
If @dberlin wants to send a PR I can review it. Otherwise I'll get to it myself at some point. > Bonus question: does this fix issues with the way...
Have I? I don't have any recollection of that.
I support being able to use the form; that doesn't mean I'm in support of every particular instance. I'm neutral in this case.
For the first part, we think this can be clarified by replacing the second sentence with > For values with identity, the _specification identity_ of those values determines the result...
Hmm. This does simplify the algorithms, but I'm not sure it's actually an improvement, especially given that many uses [e.g.](https://tc39.es/ecma262/multipage/keyed-collections.html#sec-add-entries-from-iterable) deterministically know that the iterator is not closed at the...
There's another 7 coming in [iterator helpers](https://tc39.es/proposal-iterator-helpers/), another 2 in [Set methods](https://tc39.es/proposal-set-methods/), and another 8 in [temporal](https://tc39.es/proposal-temporal/), all of which only call IteratorClose on iterators known to be open at...
Unfortunately we can't make that change for [IfAbruptRejectPromise](https://tc39.es/ecma262/multipage/control-abstraction-objects.html#sec-ifabruptrejectpromise), because in that case the macro is returning a normal completion (containing a rejected promise) from the containing algorithm. So the value...
In editor call @michaelficarra was also not in favor of this PR as-is, and didn't think that `IteratorCloseIfNotClosed` was necessary either.