Ben Anderson

Results 21 comments of Ben Anderson

Yeah I think that's a good point, but this previously worked under rack 2.x, so it could be considered a breakage from that change? I think if not supporting that...

To add some more detail there, I've been watching changes like https://github.com/rails/rails/pull/54635 and https://github.com/rails/rails/issues/54334 and it's not clear exactly what the rails position the rack change / back-porting a fix...

Haha yeah that's what I ended up doing, just seems worth a warning or documentation or something?

I agree Rails-bot, but I just wanted to know if this should be documented or an error? I am happy to do that work if someone can provide the guidance...

Here's the diff I used to generate the above diffs ``` ❯ git --no-pager diff --no-ext-diff -p diff --git a/package.json b/package.json index 01d8843..8ca26d5 100644 --- a/package.json +++ b/package.json @@ -74,8...

> This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions....

I've had a crack at solving this in the linked PR.

> Thanks and apologies for the delay here. > > [@bagedevimo](https://github.com/bagedevimo) thanks for the example change -- I'll flag this to the team internally to review and hopefully we can...

Please don't stale this stale-bot.

> This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions....