CRAFT-Reimplementation icon indicating copy to clipboard operation
CRAFT-Reimplementation copied to clipboard

Bug report: random crop

Open ThisIsIsaac opened this issue 6 years ago • 7 comments

If the thread goes into this branch, incorrect images like below occur:

ballet_106_102_after_processing

If it goes to the else branch, the results are fine:

ballet_106_102_after_processing

I think this is because the coordinates of character boxes are not adjusted properly in the first branch.

ThisIsIsaac avatar Nov 13 '19 08:11 ThisIsIsaac

@ThisIsIsaac I had not noticed this bug, I will check it .Thanks for you comment.

backtime92 avatar Nov 22 '19 04:11 backtime92

have u solved the bug? can u share the correct code? THX

chenhaolin1989 avatar Dec 02 '19 08:12 chenhaolin1989

@chenhaolin1989 I quick-fixed it by getting rid of the branch. This isn't ideal as it won't apply certain distortions.

ThisIsIsaac avatar Dec 02 '19 09:12 ThisIsIsaac

Thanks, I try to just ignore the such crop augmentation and will check the performance change after I get the results.

chenhaolin1989 avatar Dec 02 '19 09:12 chenhaolin1989

@ThisIsIsaac @chenhaolin1989 sorry for the late reply, I have checkit ,but i did not find the bug. Can you share me more details.

backtime92 avatar Jan 07 '20 07:01 backtime92

@backtime92 I don't think it is a bug, while the existing random crop strategy may cause that many input samples don't have GT bbox which may decrease the performance.

chenhaolin1989 avatar Jan 07 '20 14:01 chenhaolin1989

@chenhaolin1989 Maybe we are seeing different outputs. In my case, it wasn't that they weren't boxed. There were boxes, but all the boxes were shifted to the right by a few centimeteres.

ThisIsIsaac avatar Jan 10 '20 11:01 ThisIsIsaac