charts icon indicating copy to clipboard operation
charts copied to clipboard

Published 20 hours ago • verified publisher icon backstage

Adds support for hostAliases

Open pcc-damatj opened this issue 1 year ago • 3 comments
trafficstars

Description of the change

Adds support for hostAliases

Existing or Associated Issue(s)

Closes https://github.com/backstage/charts/issues/204

Additional Information

Checklist

  • [X] Chart version bumped in Chart.yaml according to semver.
  • [X] Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • [X] JSON Schema generated.
  • [X] List tests pass for Chart using the Chart Testing tool and the ct lint command.

pcc-damatj avatar Jul 15 '24 16:07 pcc-damatj

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Jul 23 '24 06:07 github-actions[bot]

Hey @pcc-damatj , would you be able to add some ci tests maybe for this?

ChrisJBurns avatar Jul 27 '24 14:07 ChrisJBurns

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Aug 04 '24 06:08 github-actions[bot]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Aug 21 '24 06:08 github-actions[bot]

@pcc-damatj DId you manage to run the pre-commit hook? As the CI actions seems to be failing on that step

ChrisJBurns avatar Aug 21 '24 13:08 ChrisJBurns

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Aug 30 '24 06:08 github-actions[bot]

I still think the PR is valid, it just needs rebasing and running of the pre-commit steps

ChrisJBurns avatar Sep 05 '24 20:09 ChrisJBurns

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Sep 14 '24 06:09 github-actions[bot]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Sep 26 '24 06:09 github-actions[bot]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Oct 04 '24 06:10 github-actions[bot]

@pcc-damatj Did you wan this change to be added? If you haven't got the time I could put a quick PR up and get it in

ChrisJBurns avatar Nov 04 '24 15:11 ChrisJBurns

Superseded by #234

coreydaley avatar Nov 11 '24 15:11 coreydaley

Closing because functionality was added in https://github.com/backstage/charts/pull/234

ChrisJBurns avatar Nov 13 '24 19:11 ChrisJBurns