backstage icon indicating copy to clipboard operation
backstage copied to clipboard

Changing shrinking screen size entity title behavior

Open SnowBlitzer opened this issue 1 year ago • 3 comments

Hey, I just made a Pull Request!

It seems some work done for screen sizing has been lost (ex this PR) and longer names get cut off for entities and the formatting of the header can become jumbled.

For both better readability and easier accessibility, I've made it so the name wraps to keep the user provided with full information and formatted the owner, lifecycle, and menu to always stay together and move as unit.

Before: Screenshot 2024-05-23 at 10 44 15 AM Screenshot 2024-05-23 at 10 44 43 AM Screenshot 2024-05-23 at 10 44 55 AM

After: Screenshot 2024-05-23 at 10 45 27 AM Screenshot 2024-05-23 at 10 45 21 AM Screenshot 2024-05-23 at 10 45 15 AM

:heavy_check_mark: Checklist

  • [x] A changeset describing the change and affected packages. (more info)
  • [ ] Added or updated documentation
  • [ ] Tests for new functionality and regression tests for bug fixes
  • [x] Screenshots attached (for UI changes)
  • [x] All your commits have a Signed-off-by line in the message. (more info)

SnowBlitzer avatar May 23 '24 14:05 SnowBlitzer

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-catalog plugins/catalog patch v1.20.1-next.0

backstage-goalie[bot] avatar May 23 '24 14:05 backstage-goalie[bot]

If I can make a suggestion, I would definitely prefer that the title show an ellipsis and have a tooltip show the full name when you roll over with the mouse. Part of the reason is that on long names like this it is hard to tell if there is an actual line-break in the name.

joshjung avatar May 23 '24 17:05 joshjung

@joshjung an entity name shouldn't support line breaks in the name in the standard catalog config. Is this something that you're seen users override?

The hover tool tip still shows the full, none-wrap and none-formatted name if there is any confusion there. Seems like adding a step to a user's information consumptions for an edge case feels bad from their perspective

SnowBlitzer avatar May 23 '24 20:05 SnowBlitzer

Yeah it's just a personal preference having done frontend for a long time, I don't enjoy when large titles wrap a ton within words as it can cause confusion and it causes the page layout to end up looking odd. Feel free to carry on.

joshjung avatar May 28 '24 15:05 joshjung

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Jun 25 '24 09:06 github-actions[bot]

@camilaibs I think this is a great compromise!

joshjung avatar Jul 12 '24 20:07 joshjung

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Jul 30 '24 13:07 github-actions[bot]