Thomas Jaggi
Thomas Jaggi
@Snugug, since you have been merging the last few PRs: Would you be willing to review this one? Thanks in advance!
I had to remove the `grunt-node-inspector` dependency and use Node 6.
`tweetId` is declared inside `process_data()` (using `var`). Instead, you could declare it at the same time as `since_id` (https://github.com/davidbauer/Instacurate/blob/master/script.js#L225).
You don't have to declare a value, by default it is `undefined`. `process_data()` has access to this variable, so you don't need to pass it as a parameter.
I guess `generateEmbed` is not called anymore: https://github.com/davidbauer/Instacurate/blob/master/script.js#L370 EDIT: Nope, not the issue.
Hm, it currently works for me. I get a 500 on http://tlinkstimeline.appspot.com/statuses/home_timeline.json every now and then, but apart from that, it works fine. Can you elaborate on "it won't work"...
Unverified assumption: https://github.com/vitejs/vite/tree/main/packages/plugin-legacy might help here.
Sure, I have reapplied the changes to the current master.
I have opened a PR fixing IE9+: https://github.com/bevacqua/horsey/pull/50
I have added an option `scrollToSelectedItem` for this behavior: https://github.com/unic/horsey/commit/a15ad4308d9cc97a2d1ab84e8d483c671b3bd4d8 If it works fine in a current project, I will add an example and open a pull-request.